You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Timeout library sets the status code of timed out requests to 0. This may cause issues for a number of people because of the following:
0 is a boolean value for false and may interfere with pre-existing logic as no other code will return falsy
There is no clear documentation saying what the status code will be (my first assumption was either a 408 Request Timeout, or 504 Gateway Timeout)
It would be nice if we either used an existing status code, or allow the status code to be set by the user in the forRoot so that they can prevent the use of magic numbers in their application.
The text was updated successfully, but these errors were encountered:
Timeout library sets the status code of timed out requests to
0
. This may cause issues for a number of people because of the following:0
is a boolean value for false and may interfere with pre-existing logic as no other code will return falsy408 Request Timeout
, or504 Gateway Timeout
)It would be nice if we either used an existing status code, or allow the status code to be set by the user in the
forRoot
so that they can prevent the use of magic numbers in their application.The text was updated successfully, but these errors were encountered: