New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search configuration is overly verbose #368

Open

joshmoore opened this issue May 2, 2022 · 0 comments

Member

joshmoore commented May 2, 2022

I'd suggest a refactoring of the lines:

https://github.com/IDR/deployment/pull/359/files#diff-4b5e0688f759e08318ded09e063f8c28241549014b4d5fb9b3525f04617eb285R135-R262

minimally providing a helper function would make the code more readable
perhaps running all the statements in one command would also reduce overhead
if those statements were in a script or helper, then that could be re-used elsewhere (e.g. in other dockers). however, a role would also be an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment