Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimizationResultHDF5Writer should accept OptimizeResult #1526

Open
dweindl opened this issue Nov 27, 2024 · 0 comments
Open

OptimizationResultHDF5Writer should accept OptimizeResult #1526

dweindl opened this issue Nov 27, 2024 · 0 comments
Assignees

Comments

@dweindl
Copy link
Member

dweindl commented Nov 27, 2024

OptimizationResultHDF5Writer should accept OptimizeResult, because that is what it is supposed to store. Currently, it requires a Result.

@dweindl dweindl self-assigned this Nov 27, 2024
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 27, 2024
Previously, only `Result` was supported.

Closes ICB-DCM#1526.
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 27, 2024
Changes:
*  `OptimizeResult`, `OptimizerResult`(s) can be written by `OptimizationResultHDF5Writer.write()` (Closes ICB-DCM#1526)
*  `OptimizerResult`s can be written incrementally by `OptimizationResultHDF5Writer.write_optimizer_result()` (Closes ICB-DCM#1527)
* Fixed an `AttributeError` in `pypesto.store.save_to_hdf5.check_overwrite` with `h5py.Group`s
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2024
Changes:
*  `OptimizeResult`, `OptimizerResult`(s) can be written by `OptimizationResultHDF5Writer.write()` (Closes #1526)
*  `OptimizerResult`s can be written incrementally by `OptimizationResultHDF5Writer.write_optimizer_result()` (Closes #1527)
* Fixed an `AttributeError` in `pypesto.store.save_to_hdf5.check_overwrite` with `h5py.Group`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant