Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Pesto as Matlab package? #153

Open
paulstapor opened this issue Feb 2, 2018 · 7 comments
Open

Restructure Pesto as Matlab package? #153

paulstapor opened this issue Feb 2, 2018 · 7 comments

Comments

@paulstapor
Copy link
Collaborator

One question to the other developers and users:
As Daniel has pointed out recently, we could use the idea of package folders (see https://de.mathworks.com/help/matlab/matlab_oop/scoping-classes-with-packages.html)
to restructure Pesto: We could have an own namespace and subfolders, which need not to be added to the Matlab path.

That would probably break compatibility, since Pesto commands would have to be called in different manner, e.g. Pesto.getOptimization() or Pesto.getProfiles()...
However, it would make things somewhat cleaner, I think. Any opinions on that?

@FFroehlich
Copy link
Collaborator

I would prefer if parameters would actually be turned into a class and this scoping would be handled internally and not exposed to the user.

@dweindl
Copy link
Member

dweindl commented Feb 2, 2018

@FFroehlich : Something like this?

p = PestoProblem(costFun)
p.setBounds(...)
...
p.getMultiStarts(...)
p.getParameterProfiles(...)
p.getParameterSamples(...)

@FFroehlich
Copy link
Collaborator

yes

@paulstapor
Copy link
Collaborator Author

paulstapor commented Feb 2, 2018

Looks nice. However, users would need to change their Pesto code. But I think that's worth it...
May this cause trouble when using the Matlab-compiler?

@willigott
Copy link

Sounds good. What is the status there? Just wondering whether it is worth waiting for the new structure... :)

@paulstapor
Copy link
Collaborator Author

We are also currently thinking about moving from Matlab to Python, or: also providing a Python interface. It is currently not clear, whether there will be a restructuring of the Matlab-version of PESTO according to this issue, or if this will be left to the Python version.
I think we will start working on this in roughly 1 - 2 months, so it depends what the time scale of your project is...

@willigott
Copy link

Oh, that is fantastic news! I am far more familiar with Python than with Matlab so this would help a lot. Let me know if I can be of any help there! You might want to look into tellurium i.e. the packages it uses which already offer(s) a great way of generating models, has full SBML support and makes also use of CVODE. It lacks, however, the parameter estimation part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants