Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cleanup test infrastructure #171

Open
abmusse opened this issue Jun 20, 2023 · 1 comment · May be fixed by #172
Open

test: cleanup test infrastructure #171

abmusse opened this issue Jun 20, 2023 · 1 comment · May be fixed by #172
Assignees

Comments

@abmusse
Copy link
Member

abmusse commented Jun 20, 2023

  1. Create our own libray/schema to hold test tables, procedures, etc
  2. No longer use QIWS.QCUSTCDT for insert tests (Use our own test tables)
  3. Add after/afterEach hooks to delete data inserted by test cases (remove created tables, etc)

I've noticed when running the test suite multiple times this test case in asyncStatementTest.js leads to assertion error here this is because it inserts into the QIWS.QCUSTCDT table each time and the number results increase. Therefore no way to assert that value is 1. One way to workaround this would be to check is the results are > 0. I would rather not insert into that table at all though and use our own tables. Cleaning up after the case is finished.

@abmusse abmusse added the test label Jun 22, 2023
@abmusse abmusse linked a pull request Jul 6, 2023 that will close this issue
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Jul 22, 2023
@abmusse abmusse added keep-open and removed stale labels Jul 22, 2023
@abmusse abmusse self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant