Searching for budgets by currency may not give complete results because

[simon-20]

Brief Description
The budget value @Currency attribute is required, unless you specify a default currency. The default can be specified at the iati-organisation level, or the iati-activity level.

At present the budget_value_currency Solr field used for searching is populated only via the @Currency attributes set on the budget/value element. If there is a default currency specified, this will not be populated into this field.

This means that if you wanted to search for budgets by currency, you wouldn't be guaranteed to get complete results, because it wouldn't pick up the results for budget/value elements which relied on the default currency value.

Severity
Low

[odscjames]

Fixing this at the organisation level is going to be hard.

But fixing this at the activity level should be easier - the Flattener class is handed the whole activity and gives back the whole result so we can have some special code in there, like we already do for dates. https://github.com/IATI/refresher/blob/develop/src/library/flatten.py#L23