Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we do better reporting for non-activity files #277

Open
odscjames opened this issue Aug 4, 2023 · 1 comment
Open

Can we do better reporting for non-activity files #277

odscjames opened this issue Aug 4, 2023 · 1 comment

Comments

@odscjames
Copy link
Contributor

odscjames commented Aug 4, 2023

Currently any non-activity files (eg an org file) are not processed, which is fair, as they don't end up anywhere.

But the reporting from the system makes it look as if the files are just stuck, as it doesn't distinguish between files currently being processed and files that won't be processed (I think).

eg https://validator.iatistandard.org/organisation/onl - the IATI_NL-KVK-27108436.xml file

If you click on a file on that page you get a details page that says type, but it would be good to have on first page.

(It's the db.getValidActivitiesDocsToCopy function that loads docs to clean and ignores any non-activity ones by checking "val.report ->> 'fileType' = 'iati-activities'" )

@akmiller01
Copy link
Contributor

If it's a matter of clearer reporting, you could change the "N/A" here to something like "Organisation file": https://github.com/IATI/validator-web/blob/develop/src/utils/document.js#L126

If it would help, you could also store org/activity distinction in a separate field in the DB. But I don't think it's hard to fetch it from the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants