Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on "hypermedia removal" #7

Open
lanthaler opened this issue Jul 7, 2017 · 2 comments
Open

Decide on "hypermedia removal" #7

lanthaler opened this issue Jul 7, 2017 · 2 comments

Comments

@lanthaler
Copy link
Member

Should Heracle's remove hypermedia controls from the payload or not? If so, should it do so optionally? Or should this be done at a higher layer?

@tpluscode
Copy link
Contributor

I think that Heracles should not remove hypermedia. I'd keep the representation as close as possible to the vocabulary to lower the barrier of entry. Principle of least astonishment and whatnot.
IMO, removal should be up to another component it so desires.

@alien-mcl
Copy link
Member

Current implementation by default strips of the hypermedia controls from the original resource's payload, but this behavior is driven with a single bool flag which can be set to false as a default.
JsonLdHypermediaProcessor implemented now traverses the response and adds hypermedia to the separate object which is then framed so no other data leaks to the public API.
I'm OK with having a default behavior that leaves the hypermedia in the original payload. I can give it a try and just reframe the resource to obtain hypermedia (without traversing it) but publicly available objects will have non-hypermedia related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants