Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LEAP-1322: Remove Stale Feature Flag - ff_back_2070_inner_id_12052022_short #6727

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Nov 27, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Remove long time stale feature flag
I need to wait for selenium here and other test, since LD show enabled for tests

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6393324
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/674671d5ca6f6400083c61bf

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6393324
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/674671d51afb8100083fd648

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (60cb337) to head (6393324).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6727   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          170      170           
  Lines        13883    13880    -3     
========================================
- Hits         10658    10656    -2     
+ Misses        3225     3224    -1     
Flag Coverage Δ
pytests 76.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr force-pushed the fb-leap-1322/remove-stale-feature-flag---ffback2070innerid12052022short branch from 1af5438 to 6393324 Compare November 27, 2024 01:11
@luarmr luarmr merged commit fcdb056 into develop Nov 27, 2024
43 checks passed
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants