Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch to zoom #65

Closed
dchenk opened this issue Mar 21, 2019 · 2 comments
Closed

Pinch to zoom #65

dchenk opened this issue Mar 21, 2019 · 2 comments

Comments

@dchenk
Copy link

dchenk commented Mar 21, 2019

@Hikari9 thanks for this wonderful tool. It works great. I'm planning on addressing issue #60 but am wondering if you'd want to support pinching to zoom in or out. Seems like something this app should be able to handle well. What do you think?

@Hikari9
Copy link
Owner

Hikari9 commented Mar 21, 2019

Thanks for reaching out, @dchenk. #60 would be great!

Although for pinch zoom, I'm kind of opinionated on it.

Several attempts have actually been made, namely #8, #29, #46. The main reason we're putting it on air is because it's inconsistent as of the moment. There's still no way to do "smooth pinch" in the OS that can keep up with accuracy of hardware (at least that I am aware of).

The only available way to execute global pinch is the non-fine-tuned Ctrl {+,-}. libinput is really accurate in detecting pinch, but the OS itself has only finite pinch. There's also such a thing as 3-finger and 4-finger pinch, which conflicts (sometimes) with the swipe.

Other libraries like fusuma and libinput-gestures are already doing it with keyboard commands, but I don't want to mimic them for the sake of pinch. Comfortable-swipe's swipe gesture was made differently compared to the abovementioned libraries after all ☺

TLDR; So if you're gonna help out in #60, that will be really great! Pinch is still under debate, no need to put it out there yet.

@Hikari9
Copy link
Owner

Hikari9 commented Mar 21, 2019

PS: You might have noticed the unconventional file structure and lack of CMAKE. If you're an expert in packaging, feel free to shake up the structure to your preference while working on #60 and I'll take a look at it 🚀

@Hikari9 Hikari9 closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants