Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limiting #193

Open
ayush-goyal opened this issue Oct 15, 2023 · 0 comments
Open

Fix rate limiting #193

ayush-goyal opened this issue Oct 15, 2023 · 0 comments
Assignees

Comments

@ayush-goyal
Copy link
Member

ayush-goyal commented Oct 15, 2023

The rate limiting currently works by rate limiting by ip address. However, during events since everyone is on the same wifi, it basically blocks everyone during critical moments (like registration or judging) since all the requests come from the same ip address. Fix this by doing rate limiting by user, and if they're not logged in, then rate limit by ip address.

Try to put this rate limiting as far up in the middleware as possible so that we don't waste resources for requests that should be rate limit blocked.

@reesewang25 reesewang25 self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants