Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Toggle for hover feature so that hover conversion can be enabled/disabled. #66

Open
Ankit-Kulkarni opened this issue Nov 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Ankit-Kulkarni
Copy link

Ankit-Kulkarni commented Nov 17, 2022

Is your feature request related to a problem? Please describe.
The extension is super useful to quickly see timestamps conversions using hover but anytime you navigate the code base and a number is hovered the conversion tooltip appears. After a while it becomes annoying to see tooltip every time you hover a number even if the number if not required to be converted. currently i have to disable extension and enable it every time it needs to be used.

Describe the solution you'd like
Instead of disabling an extension It would be better to have an option to toggle hover behaviour on/off. This will also save a lot of not needed conversion. When required hover functionality can be toggled .

Alternatives/workaround
The workaround recently I used to fix this is using Toggle
extension by adding a hotkey to disable hover by disabling settings on the fly however it still shows "Col 1: " after hovering and that still needs to fixed. Here is the setting i have put in my personal keybindings

{
    "key": "F4",
    "command": "toggle",
    "when": "editorIsOpen",
    "args": {
        "id": "timeconverter",
        "value": [
            {
                "timing.hoverTimestamp.enabled": true,
                "timing.hoverDuration.enabled": true,
            },
            {
                "timing.hoverTimestamp.enabled": false,
                "timing.hoverDuration.enabled": false,
            }
        ]
    }
}

Additional context
When I am seeing a file filled with timestamps hover make much more sense but sometimes I don't need to know the human time because have to work with the file in timestamp manner only. That time every time you move your mouse the tooltip shows up.

@Ankit-Kulkarni Ankit-Kulkarni changed the title t Request to add Toggle for hover feature so that hover conversion can be enabled/disabled. Nov 17, 2022
@HaaLeo HaaLeo added the enhancement New feature or request label Nov 18, 2022
@HaaLeo
Copy link
Owner

HaaLeo commented Nov 18, 2022

Hi @Ankit-Kulkarni thx for contributing this feature request. So you'd like to have an additional command to toggle the hover on/off. Sounds valid to me.
I am just thinking whether there should be a command for each hover provider (timestamp/duration) or one command to disable both of them at once.
Any thoughts?

@Ankit-Kulkarni
Copy link
Author

Ankit-Kulkarni commented Nov 20, 2022

@HaaLeo thanks for considering this feature. I feel one command makes better use case because if you make it two when you enable/disable both you always have to do it 2 times for enable/disable. One click toggle is always a good idea and fast approach

If at all may be enabling disabling multiple hover is valid use case, the toggle setting can possibly be customised to include enable/disable single or both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants