Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main fix state loading #700

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Main fix state loading #700

merged 3 commits into from
Nov 29, 2024

Conversation

EdwardMoyse
Copy link
Collaborator

FINALLY I think I understand what was going wrong in #570

Was this line:

    this.toggleState !== undefined && this.onToggle?.(this.toggleState);

We apparently only save toggleState if it is true, so absence of it should be false (or in other words, everything is off by default unless explicitly stated to be on).

@EdwardMoyse EdwardMoyse merged commit 0ec494f into main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant