-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making nice images with Phoenix #451
Comments
@sponce @EdwardMoyse Can I work on this feature? |
You're more than welcome ! |
I have tried to add an option for exporting SVG. I am successfully able to download an SVG image. But, there are a few issues:
I have basically added a function similar to makeScreenshot() in "packages\phoenix-event-display\src\managers\three-manager\index.ts":
|
I would like to reiterate the desire for this feature (and/or also #581). I tried to emulate a device with a higher resolution and take a better screenshot with that but sadly in the end they look the same still. |
I think quite a lot of this has been added. Did you give it a try - you can now make very large screenshots. |
Yeah, i did, both with https://phoenixatlas.web.cern.ch/PhoenixATLAS/ as well as cloned and run locally. I can do the preset 3860 by 2610 but that still looks quite rough to me when you zoom in even a tiny bit. Setting it bigger to twice each just gives me a grey picture. |
Which browser? If you can, try with another as I believe they have different limits. |
I used chrome initially and also tried edge now. Both give me the same result. |
I think this one is just a duplicate of #581 and we only need to find the time to implement the second point described there, and implement a solution using setViewOffset and recomposition of the image |
One thing people from the outreach like to get is nice pictures which can be used then by media in general and newspapers in particular. These picture need decent resolution (4K or more typically). Now phoenix is only able to produce screenshots, so requires you have a very big screen if you want a nice picture.
Is there anyway to get a "screenshot" of a virtual screen of a size different from the actual one ? Alternatively does threejs support svg as an output for images ?
The text was updated successfully, but these errors were encountered: