add support for Process Credentials Provider #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
reviewed
Nov 21, 2024
Comment on lines
+590
to
+594
| stdout=asyncio.subprocess.PIPE, | ||
| stderr=asyncio.subprocess.PIPE, | ||
| stdin=asyncio.subprocess.PIPE, | ||
| ) | ||
| stdout, stderr = await process.communicate(b"") |
There was a problem hiding this comment.
This would block if the subprocess produces too much data.
Arguably there should be a default timeout too, although, perhaps in this particular library, the caller has a timeout and will cancel fetch_metadata.
A simple fix could look smth like:
try:
stdout, stderr = await asyncio.wait_for(
process.communicate(b""), timeout=30
)
except asyncio.TimeoutError:
process.kill()
await process.wait()
raise ProcessCredentialsError("Subprocess timed out", None, b"", b"")I dunno if it's worth it in practice.
dimaqq
reviewed
Nov 21, 2024
| ) | ||
| try: | ||
| data = json.loads(stdout) | ||
| except json.JSONDecodeError: |
There was a problem hiding this comment.
Hmmm I can't recall if they fixed this or not. Back in the day, except ValueError was better, because JSONDecodeError inherits from it, and in some special cases loads could raise a plain ValueError?
dimaqq
reviewed
Nov 21, 2024
| def try_decode(data: bytes) -> str: | ||
| try: | ||
| return data.decode() | ||
| except: |
There was a problem hiding this comment.
Suggested change
| except: | |
| except Exception: |
unless the intention is to swallow e.g. SystemExit if it happens at just the right time.
dimaqq
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Process Credentials Provider