Rework the compression library search #5085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
The search path for libs can be controlled by CMake system variables - see https://cmake.org/cmake/help/latest/command/find_package.html |
CMakeFilters.cmake
Outdated
| @@ -92,7 +98,8 @@ if (HDF5_ENABLE_ZLIB_SUPPORT) | |||
| else () | |||
| set(ZLIB_SEACH_TYPE shared) | |||
| endif () | |||
| find_package (ZLIB NAMES ${PACKAGE_NAME} COMPONENTS ${ZLIB_SEACH_TYPE}) | |||
| # Search pure Config mode first | |||
| find_package (ZLIB NAMES ${PACKAGE_NAME} OPTIONAL_COMPONENTS ${ZLIB_SEACH_TYPE}) | |||
There was a problem hiding this comment.
ZLIB_SEACH_TYPE -> ZLIB_SEARCH_TYPE
lrknox
reviewed
Nov 21, 2024
lrknox
previously approved these changes
Nov 21, 2024
lrknox
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default names for search use.