Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document release workflow #310

Open
SRichner opened this issue May 1, 2024 · 1 comment
Open

Document release workflow #310

SRichner opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@SRichner
Copy link
Collaborator

SRichner commented May 1, 2024

https://www.electron.build/configuration/publish.html#recommended-github-releases-workflow

same as recommended,

  • update version in package
  • push to main
  • create draft release
  • tag prefix version with v
@AlexanderLill
Copy link
Member

AlexanderLill commented May 3, 2024

Thanks for the issue!

Just adding a bit more detail as I am "fresh" to GitHub workflows and might know the least about it :)

According to the official electron recommendations[1]

  • update version in src/electron/package.json (what about package-lock.json?)
  • push commit to main (this happens before creating the draft release?)
  • create draft release in GitHub ("Draft a new release"-button on [2])
  • tag prefix version with v${version}, e.g. v0.0.20 (git-tag and push to main? Or is this the content of the version-field that needs to be specified when creating a new release according to the previous step?)
  • Project builds and automatically puts build assets into the created draft release (is that what indeed happens?)

[1] https://www.electron.build/configuration/publish.html#recommended-github-releases-workflow
[2] https://github.com/HASEL-UZH/PersonalAnalytics/releases

@casaout casaout self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants