Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleft Texture Improvements (Zandi Props & Skybox) #263

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

patmauro
Copy link
Contributor

@patmauro patmauro commented Nov 2, 2024

Equivalent to Commit 0a34a4 of content/144 ("Cleft Revamp Bundle 1") in the OpenUru Foundry, included in the Q3 2024 update to MOULa. (For submission to H'uru I am splitting this bundle into three separate PRs for increased modularity.)

First batch of a planned series of improvements to help modernize The Cleft:

  • Gives "ClftBeerCan" a facelift that reads more clearly as a water bottle and makes sure the "Sponakee" joke is actually legible.
  • Slightly bumps up the res on ClftCD so this reads more clearly.
  • In keeping with MOUL's intended "current day" setting, gives ClftChipsBag a "modernized" redesign (created entirely from scratch with 100% original assets) so Zandi does not appear to be eating from a 30-year-old bag.
  • Slightly bumps up the res on ClftRadioMap (but only slightly - the full res we have available in the original assets is far larger than is necessary.)

In addition: The Cleft's skybox appears noticeably lower-res compared to other ages, which is unfortunate as this is a very important location. To address this, this change bumps up the res on ClftSky3 to the original texture resolution (2x). (Note: @Hoikas and I investigated various compression methods on this and were unable to find one that did not introduce any noticeable artifacts to the in-game sky - so I can understand if that makes this particular change controversial/unacceptable for H'uru/moul-assets.)

Note: I assessed several other objects in my tests as well, such as the chair, table grain, grill, cooler, etc, but did not find that there was any noticeable or worthwhile improvement in these cases - the set I've prepared here seem to be the only of Zandi's props that actually benefit from TLC.

image
image

image
image

@Hoikas Hoikas added visual An issue or fix that is primarily visual subjective An issue or fix that is artistic or creative in nature labels Nov 3, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update or add the new textures to the textures directory in this repository?

@Hoikas Hoikas added the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Can you update or add the new textures to the textures directory in this repository?

I can do that - CD, radio and sky are already good, but chips bag is new, and water bottle has been altered enough that it may be worth saving in the textures as well. I will add these to "sources/textures/tga/Cleft" as "clftBeerCanNew" and "clftChipsBagNew" if that sounds good.

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

Sure. If the old version is already in the repo, you can just replace it. The old version will still be available in git history.

@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Sure. If the old version is already in the repo, you can just replace it. The old version will still be available in git history.

Done. Let me know if any issues.

@Hoikas Hoikas removed the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beer can's increase in resolution by 4x is maybe a little much, but I think the Textures PRP and VRAM budget are still respectable.

@Hoikas Hoikas merged commit ce8073a into H-uru:master Nov 3, 2024
1 check passed
@patmauro
Copy link
Contributor Author

patmauro commented Nov 4, 2024

The beer can's increase in resolution by 4x is maybe a little much, but I think the Textures PRP and VRAM budget are still respectable.

Yes, this was definitely the outlier here - not sure if it has to do with the mesh or whatever, but that's the smallest I could get it and keep it still legible. Needless to say I doubt I'll be making any further changes like this one anytime soon. Thanks for taking a chance on this one though - I think making sure the little jokes Cyan put in are legible is a net positive for Uru.

@patmauro patmauro deleted the cleftTextureRevamp branch November 4, 2024 00:30
@Hoikas
Copy link
Member

Hoikas commented Nov 4, 2024

S3TC's block compression algorithm is a pain for that, and I don't know that we're ever going to be able to use anything more modern, given the pushback we get on even more modest tech upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subjective An issue or fix that is artistic or creative in nature visual An issue or fix that is primarily visual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants