Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link Panel for Rainy Cleft #262

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

patmauro
Copy link
Contributor

@patmauro patmauro commented Nov 2, 2024

Equivalent to Commit 3df27e of content/144 ("Cleft Revamp Bundle 1") in the OpenUru Foundry, included in the Q3 2024 update to MOULa. (For submission to H'uru I am splitting this bundle into three separate PRs for increased modularity.)

Fixes an aesthetic issue introduced by MOUL: When Classic Uru was updated for MOUL, almost all linking panels in the game received a graphical overhaul with the notable exception of the panel for Rainy Cleft, which did not change even though Sunny Cleft's panel did. As a result, the panels no longer mirror each other like they did in the base Uru game. This fix addresses this by introducing a new panel for Rainy Cleft that more properly mirrors the updated panel for Sunny Cleft.

Before
image

After
image

@dpogue
Copy link
Member

dpogue commented Nov 2, 2024

Out of curiosity, was this taken from a direct screenshot in game, or was it brightened before being added as a texture? It seems significantly darker than the original (and while yes, some of Cyan's artificially lightened linking panels are brightened to the point of being washed out, it seems like some middle ground might be possible with this particular case)

I do like matching the perspective 👍

@patmauro
Copy link
Contributor Author

patmauro commented Nov 2, 2024

Out of curiosity, was this taken from a direct screenshot in game, or was it brightened before being added as a texture? It seems significantly darker than the original (and while yes, some of Cyan's artificially lightened linking panels are brightened to the point of being washed out, it seems like some middle ground might be possible with this particular case)

I do like matching the perspective 👍

I did touch this up slightly, but I honestly prefer the much clearer contrast this offers. In addition, the response from those who tested this in-game while preparing the Q3 update has been extremely positive; had I received any feedback asking to adjust this more I might have taken another look but at this time I'm happy with it where it is.

@Hoikas Hoikas added visual An issue or fix that is primarily visual subjective An issue or fix that is artistic or creative in nature labels Nov 3, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added the new texture to sources/textures?

@Hoikas Hoikas added the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Have you added the new texture to sources/textures?

I can do that - would you prefer I overwrite xLinkPanelTomahnaDesert.tga or add a new file, ie xLinkPanelTomahnaDesert2 or something? I'd be more comfortable going with the second option and keeping both, but your call.

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

Overwrite the original file or delete it and add a PNG. The old version will still be available in git history.

@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Overwrite the original file or delete it and add a PNG. The old version will still be available in git history.

Done. Let me know if any issues.

@Hoikas Hoikas removed the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
@Hoikas Hoikas merged commit 13a9932 into H-uru:master Nov 3, 2024
1 check passed
@patmauro patmauro deleted the updateRainyCleftPanel branch November 3, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subjective An issue or fix that is artistic or creative in nature visual An issue or fix that is primarily visual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants