Fix Linux CI.

Per @dpogue, the problem is https://gitlab.kitware.com/cmake/cmake/-/issues/25650. Long story short, CMake broke PCH and Unity on CMake 3.28.2, so disable that combination when it's used.
H-uru · Feb 4, 2024 · b289be3 · b289be3
1 parent ef73775
commit b289be3
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/cmake/PlasmaTargets.cmake b/cmake/PlasmaTargets.cmake
@@ -9,11 +9,17 @@ cmake_dependent_option(
     OFF
 )
 
+# CMake 3.28.2 breaks precompiled headers and unity builds.
+# Debounce this known bad combination.
+if(CMAKE_VERSION VERSION_EQUAL 3.28.2 AND PLASMA_USE_PCH AND CMAKE_GENERATOR MATCHES Ninja|Makefiles)
+    set(_UNITY_BROKEN TRUE)
+endif()
+
 cmake_dependent_option(
     PLASMA_UNITY_BUILD
     "Enable unity build?"
     ON
-    "CMAKE_VERSION VERSION_GREATER_EQUAL 3.16;ALLOW_BUILD_OPTIMIZATIONS"
+    "CMAKE_VERSION VERSION_GREATER_EQUAL 3.16;ALLOW_BUILD_OPTIMIZATIONS;NOT _UNITY_BROKEN"
     OFF
 )