Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script error when importing #25

Open
Ranily57 opened this issue May 30, 2024 · 8 comments
Open

Script error when importing #25

Ranily57 opened this issue May 30, 2024 · 8 comments
Assignees
Labels
Feedback/Review needed A change was made, is "it" fixed/working now? invalid This doesn't seem right

Comments

@Ranily57
Copy link

image

I have several error when importing the package !

UVU Version : 1.0.0
UdonUtils Version : 8.1.1

An error example:

[<color=#FF00FF>UdonSharp</color>] Packages/tlp.udonvoiceutils/Runtime/Core/PlayerAudioOverride.cs(404,50): error CS1061: 'PlayerList' does not contain a definition for 'DiscardInvalid' and no accessible extension method 'DiscardInvalid' accepting a first argument of type 'PlayerList' could be found (are you missing a using directive or an assembly reference?)

@Ranily57 Ranily57 added the bug Something isn't working label May 30, 2024
@Guribo
Copy link
Owner

Guribo commented May 30, 2024

It looks like you installed it via Unitypackage, this is not the recommended way as you are now missing a bunch of dependencies.

Please follow the guide in the Readme: https://github.com/Guribo/UdonVoiceUtils?tab=readme-ov-file#getting-started

I tested it again to be sure with a clean project:

image
image

(You can ignore UdonUiAnimators in these pictures, it is not needed for UVU)

@Guribo Guribo added invalid This doesn't seem right and removed bug Something isn't working labels May 30, 2024
@Guribo
Copy link
Owner

Guribo commented May 30, 2024

Maybe relevant, I think I remember seeing a similar issue after importing. It may be that some packages are not yet fully resolved by the Package Resolver. All I did was close the project and reopen it again. It would import some files and work just fine afterwards.

Please let me know if any of this helped.

@Guribo Guribo added the Feedback/Review needed A change was made, is "it" fixed/working now? label May 30, 2024
@Glynn-Taylor
Copy link

Adding the package in VCC did not add the dependency Cyan's Player Pool for me, causing similar errors, so I had to manually add that and then relaunch the project.

@Guribo
Copy link
Owner

Guribo commented Jun 20, 2024

that is expected behaviour, it is described here: https://github.com/Guribo/UdonUtils?tab=readme-ov-file#installation

There is no way I know of to automatically add the cyan repository to VCC when adding my repository...

@Glynn-Taylor
Copy link

Glynn-Taylor commented Jun 20, 2024

Ah that must be a frustrating limitation, the Readme.md for UdonVoiceUtils didn't mention it (unless I'm blind) so I thought it might resolve it automatically as I already had the player pool repo added. Maybe one day VRChat will bless us with that technology x)

@Guribo
Copy link
Owner

Guribo commented Jun 20, 2024

image
It is in the readme ;)

@Glynn-Taylor
Copy link

Ah for some reason I presumed that meant just to have the repository added to VCC and it didn't matter if it was added to the project yet my mistake x)

@Guribo
Copy link
Owner

Guribo commented Jun 20, 2024

I will update this soon, too many people struggle with that so it is obvious that it isn't clear enough, no worries :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback/Review needed A change was made, is "it" fixed/working now? invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants