-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture Matching: Allow user to specify minimum interval between capture and potential match #949
Comments
I would like to work on this |
@navDhammu thanks for putting your energy into this, the capture matching tool is the major focus for us these days. |
The situation is, we are going to deliver the beta version to our VIP client freetown, currently, the source of the beta is branch : hotfix/v1.107 Please let me know if you need any support |
@dadiorchen @sebastiangaertner This should be part of the |
@sebastiangaertner I think this rule is a bit overkill, it's possible that the planter revisits the tree within a month, we shouldn't restrain this. BTW, the dates on the UI is totally wrong, I have corrected it. |
Yeah this issue should be transferred to the treetracker-api |
@sebastiangaertner and I discussed this, to provider good flexibility, we can do:
|
@dadiorchen @sebastiangaertner I suggest a dropdown above the candidate matches that says:
I would avoid months as it will give you different behaviour depending on the time of year. @navDhammu Are you happy to make a start on this? |
Yeah I can try work on this |
@navDhammu if you checkout the hotfix-107 branch, you will find that we have set a default parameter, matching_tree_time_range, that's the parameter for this, so you just need to try to change it on the client side! |
I'm not sure what this parameter does. Does it only return potential matches captured after 30 days from the one being matched? At the moment the capture matching tool is not showing any matches in the hotfix-107 branch. |
@navDhammu there is the code: treetracker-admin-client/src/api/treeTrackerApi.js Lines 146 to 148 in 36013a8
|
@dadiorchen Nicks suggestion with a default 30days min interval is good. It's very very unlikely that prga revisit but in some cases they might want to retake the captures and reject the first round or so. |
In case anybody is picking this up. Here is more up to date design file |
See screenshot below. This is from live data in the beta admin which is now ready for testing.
The images on the right have to be at least 1month older than the one that is matched (left side) here see example.
The text was updated successfully, but these errors were encountered: