Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Add tests, check for gofmt, lint and docs #6

Open
umairidris opened this issue Jan 22, 2020 · 2 comments
Open

Add tests, check for gofmt, lint and docs #6

umairidris opened this issue Jan 22, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@umairidris
Copy link
Member

We should add unit tests as well as integration tests for the provider.
@umairidris
Copy link
Member Author

@xingao267 can you setup a cloud build trigger to make sure the provider at least builds on every release as a first step?

@xingao267
Copy link
Member

xingao267 commented Jan 24, 2020 •
edited
Loading

Some additional checks to perform can include: lint, terraform validate and validate docs are generated properly by make docker_generate_docs command.

@umairidris umairidris changed the title Add tests Add tests, check for gofmt, lint and docs Feb 12, 2020
@umairidris umairidris mentioned this issue Feb 12, 2020
Closed
@jaketf jaketf added the enhancement New feature or request label Feb 26, 2020
This was referenced Aug 24, 2021
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@umairidris @xingao267 @jaketf