Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UDF contributing docs #217

Open
danieldeleo opened this issue Mar 24, 2021 · 5 comments
Open

Update UDF contributing docs #217

danieldeleo opened this issue Mar 24, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@danieldeleo
Copy link
Collaborator

Update docs to address the issue that was surfaced in thie PR

@danieldeleo danieldeleo self-assigned this Mar 24, 2021
@sdepablos
Copy link
Contributor

Related to this, on the UDF documentation there's an explanation on how to add the UDFs to your private project, but the explanation should be improved for the cases the UDF function uses a JS function, as creating the SQL UDF in your project is not enough, you need to upload the JS file to a bucket and change the JS route.

@danieldeleo
Copy link
Collaborator Author

Thanks! good catch

@sdepablos
Copy link
Contributor

I've created a PR #218 to address it. Let me know if there's something wrong or I can improve it somehow.

@danieldeleo
Copy link
Collaborator Author

Thank you for starting the work on this! I need to evaluate the best method of having users locally test with js libs. It won't be as easy as having them copy js files to their own GCS bucket because we use webpack to bundle everything into one minified js file. I'm currently testing a method that allows users to run the Cloud Build test pipeline in their own GCP project. Will also evaluate building locally using the cloud-build-local tool but that requires having Docker installed on the local environment.

@sdepablos
Copy link
Contributor

Yes, I could only the part about adding the UDF to your private project, not the testing part.

@afleisc afleisc added the documentation Improvements or additions to documentation label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants