-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UDF contributing docs #217
Comments
Related to this, on the UDF documentation there's an explanation on how to add the UDFs to your private project, but the explanation should be improved for the cases the UDF function uses a JS function, as creating the SQL UDF in your project is not enough, you need to upload the JS file to a bucket and change the JS route. |
Thanks! good catch |
I've created a PR #218 to address it. Let me know if there's something wrong or I can improve it somehow. |
Thank you for starting the work on this! I need to evaluate the best method of having users locally test with js libs. It won't be as easy as having them copy js files to their own GCS bucket because we use webpack to bundle everything into one minified js file. I'm currently testing a method that allows users to run the Cloud Build test pipeline in their own GCP project. Will also evaluate building locally using the cloud-build-local tool but that requires having Docker installed on the local environment. |
Yes, I could only the part about adding the UDF to your private project, not the testing part. |
Update docs to address the issue that was surfaced in thie PR
The text was updated successfully, but these errors were encountered: