Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#87 Renamed fileNamePattern to jobName. #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#87 Renamed fileNamePattern to jobName. #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...a/com/google/appengine/tools/mapreduce/outputs/BigQueryGoogleCloudStorageStoreOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import com.google.appengine.tools.mapreduce.GoogleCloudStorageFileSet;
import com.google.appengine.tools.mapreduce.Output;
import com.google.appengine.tools.mapreduce.OutputWriter;
import com.google.appengine.tools.mapreduce.impl.BigQueryConstants;

import java.io.IOException;
import java.util.Collection;
Expand All @@ -25,20 +26,21 @@ public final class BigQueryGoogleCloudStorageStoreOutput<O> extends
private final MarshallingOutput<O, GoogleCloudStorageFileSet> dataMarshallingOutput;
private final BigQueryMarshaller<O> bigQueryMarshaller;
private final String bucketName;
private final String fileNamePattern;
private final String jobName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good, however do you mind to remove jobName and bucketName (they are both private and seems that they are not using outside of the constructor)....


/**
* @param bigQueryMarshaller use for generating the bigquery schema and marshal the data into
* newline delimited json.
* @param jobName Used in naming GCS objects, see {@link BigQueryConstants#GCS_FILE_NAME_FORMAT}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, do you mind to start the param description using lowercase.

*/
public BigQueryGoogleCloudStorageStoreOutput(BigQueryMarshaller<O> bigQueryMarshaller,
String bucketName, String fileNamePattern) {
String bucketName, String jobName) {
this.bigQueryMarshaller = bigQueryMarshaller;
this.bucketName = bucketName;
this.fileNamePattern = fileNamePattern;
this.jobName = jobName;
SizeSegmentedGoogleCloudStorageFileOutput sizeSegmentedOutput =
new SizeSegmentedGoogleCloudStorageFileOutput(this.bucketName, MAX_BIG_QUERY_GCS_FILE_SIZE,
String.format(GCS_FILE_NAME_FORMAT, this.fileNamePattern), MIME_TYPE);
String.format(GCS_FILE_NAME_FORMAT, this.jobName), MIME_TYPE);
this.dataMarshallingOutput = new MarshallingOutput<>(sizeSegmentedOutput, bigQueryMarshaller);
}

Expand Down