Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linting as a part of CI pipeline #392

Open
tarunsinghofficial opened this issue Aug 17, 2024 · 4 comments · May be fixed by #393
Open

Add Linting as a part of CI pipeline #392

tarunsinghofficial opened this issue Aug 17, 2024 · 4 comments · May be fixed by #393
Assignees

Comments

@tarunsinghofficial
Copy link
Contributor

Overview

We should add automated linting to our Continuous Integration (CI) pipeline to ensure consistent code style and catch potential errors early in the development process.

Current Situation

  • Currently, there is no automated linting in our CI pipeline.
  • Code style inconsistencies are being caught manually during code reviews.
  • We have .eslintrc.json and .prettierrc.json files in our repository, but they are not enforced automatically.

Proposed Solution

Add a linting step to our GitHub Actions workflow that runs on every pull request and push to main branches.

Implementation Details

  1. Create or update a GitHub Actions workflow file (e.g., .github/workflows/ci.yml).
  2. Add a linting job that includes:
    • Setting up Node.js
    • Installing dependencies
    • Running ESLint
    • (Optional) Running Prettier
@tarunsinghofficial
Copy link
Contributor Author

I'm interested in doing this issue. Let me know if it is good, and please assign the issue to me. Thanks!

@hoch
Copy link
Member

hoch commented Aug 20, 2024

Sure thing. I'll assign this to you.

@tarunsinghofficial
Copy link
Contributor Author

Sure thing. I'll assign this to you.

Hi @hoch

Please review PR #393, whenever you're free. Thanks :)

@hoch
Copy link
Member

hoch commented Sep 3, 2024

Yes. We will get to this soon after wrapping up the #395. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants