-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values like jsHeapSize change over time, whereas useMemoryStatus hook will give a constant value #19
Comments
Thanks for the feedback, @bharathnayak03. We recently switched over to a model where many of the original 'hooks' were changed to offer constant values, with the exception of the Network status hook. I see two options here:
Interested in @wmertens opinions here too... :) |
As we were using the approach from this article, I think we could revert memory status back to React.js hook and add some listener like network hook. According to my experiment, with a lot of tabs open for a long time on Chrome browser (when memory usage is quite high enough to notice), the previous memory hook based on this article used to work well. I think it could be better off evaluating memory status than just based on |
I'm just wondering if we could explore some approach with which we can evaluate the CPU usage not just the constant value. |
I would be supportive of this. I think it's worth keeping this issue open a little longer just to give more users a chance to provide more feedback before we make a decision on how to proceed. Another option would be focusing the memory utility entirely on the constant |
memory info
totalJSHeapSize
andusedJSHeapSize
change over time, whereasuseMemoryStatus
hook return value which was captured during the module load time.useInitialMemoryStatus
would have been a better name since this hook returns initial memory status.The text was updated successfully, but these errors were encountered: