Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add a demo in #1

Open
BastiaanOlij opened this issue Aug 9, 2020 · 4 comments
Open

Need to add a demo in #1

BastiaanOlij opened this issue Aug 9, 2020 · 4 comments

Comments

@BastiaanOlij
Copy link
Member

Just a reminder to ourselves, need to add a small demo project in similar to other plugins so people can see how to set things up.

@m4gr3d
Copy link
Collaborator

m4gr3d commented Aug 12, 2020

@BastiaanOlij Can you port the demo project you were using for the first ARCore PR to this plugin?

@BastiaanOlij
Copy link
Member Author

@BastiaanOlij Can you port the demo project you were using for the first ARCore PR to this plugin?

I think thats a good starting point, let me add it in and we can start making it work

@Brennanzuz
Copy link

Brennanzuz commented Sep 25, 2024

Plugin is broken in the demo project after ./gradlew assemble is done successfully. In Godot 4.3:

Godot Engine v4.3.stable.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
--- Debug adapter server started on port 6006 ---
--- GDScript language server started on port 6005 ---
Loaded system CA certificates
EditorSettings: Save OK!
  res://addons/ARCorePlugin/ARCoreInterface.gd:6 - Parse Error: Could not find type "ARCoreInterface" in the current scope.
  res://addons/ARCorePlugin/ARCoreInterface.gd:9 - Parse Error: Identifier "ARCoreInterface" not declared in the current scope.
  modules/gdscript/gdscript.cpp:2936 - Failed to load script "res://addons/ARCorePlugin/ARCoreInterface.gd" with error "Parse error". (User)
  Failed to create an autoload, script 'res://addons/ARCorePlugin/ARCoreInterface.gd' is not compiling.
  Failed to create an autoload, script 'res://addons/ARCorePlugin/ARCoreInterface.gd' is not compiling.
  editor/editor_autoload_settings.cpp:577 - Condition "!info->node" is true. Continuing.
Add Autoload
  res://main.gd:27 - Compile Error: Identifier not found: ARCoreInterfaceInstance
  modules/gdscript/gdscript.cpp:2936 - Failed to load script "res://main.gd" with error "Compilation failed". (User)
Generated 'res://addons/ARCorePlugin/ARCoreInterface.gd' preview in 3831 usec
Generated 'res://addons/ARCorePlugin/export_plugin.gd' preview in 1953 usec
Generated 'res://addons/ARCorePlugin/plugin.cfg' preview in 36 usec
Generated 'res://export_presets.cfg' preview in 20 usec
Generated 'res://main.tscn' preview in 1052 usec

Similar issue on Godot 4.2. For example, var arcore : ARCoreInterface in line 6 of ARCoreInterface.gd does not have any class called ARCoreInterface.

However, plugin works when exported to an apk and ran on the phone, though of course without camera access which I know is a WIP.

@LucaJunge
Copy link
Contributor

We are still in the process of adding support for ARCore and are not quite done yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants