Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RULE] - setStackSize item_name stack_size #107

Open
DH12043 opened this issue May 24, 2023 · 4 comments
Open

[RULE] - setStackSize item_name stack_size #107

DH12043 opened this issue May 24, 2023 · 4 comments
Assignees
Labels
feature New feature or request low priority Issue is of low priority

Comments

@DH12043
Copy link
Collaborator

DH12043 commented May 24, 2023

setStackSize

Be able to set a custom stack size for any item in the game, independently controlled for each item type

options:

item_name: select the item you wish to modify the stack size for (shows a list with all items)
stack_size: choose 1, 16, 64, or custom int for the max stack size
It also needs to have the ability to list any modified sizes and reset all to the default

@DH12043 DH12043 added the feature New feature or request label May 24, 2023
@DH12043 DH12043 changed the title [12043] - <setStackSize item_name stack_size> [RULE] - <setStackSize item_name stack_size> May 24, 2023
@DH12043 DH12043 changed the title [RULE] - <setStackSize item_name stack_size> [RULE] - setStackSize item_name stack_size May 24, 2023
@DH12043 DH12043 added the low priority Issue is of low priority label May 24, 2023
@Gilly7CE
Copy link
Owner

Gilly7CE commented May 24, 2023

This feels less like a carpet rule and more like an actual carpet feature. It could be it’s own command with its own config.

The carpet rule API is limited to boolean, string and enum types (if I remember correctly). So I’m more convinced this would be its own genuine feature purely from the implementation details. The string type might work but we’d still need to do custom parsing, and we’re need a listener on the rule all the time so we invoke the correct behaviour. Which I think could get too complicated easily

The “rule” part can just be enabling or disabling this feature

@Gilly7CE Gilly7CE added this to the 1.4.0 milestone Jun 1, 2023
@Gilly7CE
Copy link
Owner

Gilly7CE commented Jun 1, 2023

This issue can be worked on once 1.3.0 is released.

@DH12043 DH12043 self-assigned this Jun 11, 2023
@Gilly7CE Gilly7CE modified the milestones: 1.4.0, 1.3.0 Jun 11, 2023
@Gilly7CE
Copy link
Owner

Moving to 1.3.0 since @DH12043 wants to work on it.

@Gilly7CE Gilly7CE modified the milestones: 1.3.0, 1.4.0 Jul 24, 2023
@Gilly7CE Gilly7CE removed this from the 1.4.0 milestone Aug 29, 2023
@Gilly7CE
Copy link
Owner

Removing the milestone 1.4.0 as this can just be included in whatever minor version is next once it is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request low priority Issue is of low priority
Projects
None yet
Development

No branches or pull requests

2 participants