Replace MCAuth with RK_01 MinecraftAuth #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexProgrammerDE
changed the title
# Conflicts: # example/src/main/java/org/geysermc/mcprotocollib/protocol/example/MinecraftProtocolTest.java # gradle/libs.versions.toml # protocol/build.gradle.kts # protocol/src/main/java/org/geysermc/mcprotocollib/network/ProxyInfo.java # protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpClientSession.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ClientListener.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/MinecraftProtocol.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ServerListener.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/codec/MinecraftCodecHelper.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/PlayerListEntry.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/DataComponentType.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/ItemCodecHelper.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/ingame/clientbound/ClientboundPlayerInfoUpdatePacket.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/login/clientbound/ClientboundGameProfilePacket.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacket.java # protocol/src/test/java/org/geysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacketTest.java
Camotoy
reviewed
May 4, 2024
auth/src/main/java/org/geysermc/mcprotocollib/auth/util/UUIDUtils.java
Outdated
Show resolved
Hide resolved
|
Let's not just copy and paste GNU licensed code into an MIT repo and strip the license... |
|
I made that code, you have explicit permission to use it. |
|
ah yeah i remember now, sorry thanks :P |
Auth has become so small that it's not worth keeping separate
# Conflicts: # gradle/libs.versions.toml
AlexProgrammerDE
changed the title
# Conflicts: # example/src/main/java/org/geysermc/mcprotocollib/protocol/example/MinecraftProtocolTest.java # gradle/libs.versions.toml
rtm516
requested changes
Jun 13, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/auth/GameProfile.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/auth/util/HTTPUtils.java
Show resolved
Hide resolved
Kas-tle
approved these changes
Jun 17, 2024
example/src/main/java/org/geysermc/mcprotocollib/protocol/example/MinecraftProtocolTest.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/auth/util/UUIDUtils.java
Outdated
Show resolved
Hide resolved
|
Also please resolve merge conflict in ClientboundStatusResponsePacket. |
# Conflicts: # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacket.java
|
Will merge tomorrow if there are no objections. |
rtm516
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.