Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minestom support #271

Open
nicolasvac opened this issue Feb 11, 2022 · 12 comments
Open

Minestom support #271

nicolasvac opened this issue Feb 11, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@nicolasvac
Copy link

nicolasvac commented Feb 11, 2022

As minestom is rising in popularity for building custom minigame servers, it would be great to have floodgate support built in.

For reference, minestom website: https://minestom.net/

@YHDiamond
Copy link

Yea that would kind of require rewriting a stupidly large amount of code... It's not like you can just change a word in a file and it'll just magically work, the way floodgate interacts with the server's auth is made to work with Mojang code (afaik) and minestom says they have zero of mojang's code.

@Konicai
Copy link
Member

Konicai commented Feb 11, 2022

Minestom still does authentication though. And floodgate on minestom might be cleaner due to a more open API

@nicolasvac
Copy link
Author

Minestom does support Mojang Auth, and i see it as an advantage to have completely bloat free and decompiled code from Mojang.

Also in Minestom you have the ability to choose what to implement, so it definetely the could would look much cleaner for the minestom implementation.

@Codestech1
Copy link

Yes, we need it!

@Codestech1
Copy link

We need only floodgate that receives proxy floodgate data, not geyser addon.

@tbvns1
Copy link

tbvns1 commented Oct 2, 2022

I want it too. But I think it would take to rewrite the entire code of floodgate to make it work. So I won't be sad if I learn you don't want to make it.

@Camotoy
Copy link
Member

Camotoy commented Oct 2, 2022

It seems like the primary difference is that Floodgate currently relies heavily on Netty being present in the server, which Minestom does not use. That wouldn't stop anyone from creating something that reads our injected data in the handshake and parsing it properly, though. I don't think it's viable for us to maintain another platform that we aren't familiar with, anyway.

@Codestech1
Copy link

I know, it's hard. But minestom is better for optimization and it's time to move to better server software. You're made floodgate-fabroc then you can make floodgate-minestom too.

@Konicai
Copy link
Member

Konicai commented Oct 3, 2022

Just because "we can", doesn't mean we should. You've just been told that most of us are not familiar with it, and as a result, it wouldn't be maintained well. The Fabric ports of Geyser and Fabric already suffer more issues because they are lower priority.

Arguing about the priority of this and sounding entitled while doing so isn't going to move this forward anywhere.

@Codestech1
Copy link

I have idea how to make it. It will need be on Proxy and Minestom and will have custom api. It will create custom Form object that can be send in plugin messaging channel via ObjectOutputStream. When proxy reveive custom form object via ObjectInputStream it will be converted to cumulus form and sent to player.
If it's possible i will make it. Comming soon! (Sorry for bad English btw)

@Codestech1
Copy link

I made basic floodgate for minestom.
https://github.com/HEROOSTECH/Floodgate-Minestom

@Tim203 Tim203 added the enhancement New feature or request label Oct 27, 2022
@Tim203
Copy link
Member

Tim203 commented Nov 2, 2024

I'd like to know how many people would like to see Minestom support, before we'd add support for another platform. Please add a 👍 to the initial comment of this issue if you'd actually use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants