Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A_in and B_in should not be used after being assigned to the local variable AB #39

Open
pablokrupa opened this issue Sep 9, 2023 · 0 comments
Open

A_in and B_in should not be used after being assigned to the local variable AB #39

pablokrupa opened this issue Sep 9, 2023 · 0 comments
Labels
fix Things that need to be fixed

Comments

@pablokrupa
Copy link
Member

In the LaxMPC ADMM solver, A_in is used in the computation of AQiAt. However, this variable should not be used any more at this point in the code. Instead, the AB variable should be used. Same goes for B_in with BRiBt. Further ahead, A_in is also used in the computation of the Alpha matrices.

This should be fixed in this solver and in any other time-varying solver.
@pablokrupa pablokrupa added the fix Things that need to be fixed label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Things that need to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pablokrupa