New simpler dockerfile #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gdal images, which means we don't need to build anything ourselves) & should be less prone to things going out-of-date (osgeo will keep image to latest stable versions, any breakages we encounter would be us not supporting newer versions of GDAL = our problem)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is what I used to work around the issues w/ the current dockerfile (doesn't build for various reasons, which even after fixing manually I had issues using).
The new dockerfile is much simpler by building on top of the official osgeo/gdal docker image (thus all our native system dependencies are already built and ready to go, which means the dockerfile only has to care about PyRate and some nitty gritty around how we install our python deps).
This I think would also address #383