Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSLUX-659: Display attributions #87

Merged
merged 5 commits into from
Oct 19, 2023
Merged

GSLUX-659: Display attributions #87

merged 5 commits into from
Oct 19, 2023

Conversation

AlitaBernachot
Copy link
Contributor

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-659

Description

  • Enable attributions on map

@github-actions
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-659-attributions/

tkohr
tkohr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlitaBernachot! Works as expected, just left a comment regarding CSS organization. An e2e test could also be nice, but not mandatory. I'll let you decide.

src/assets/main.css Outdated
@@ -281,6 +285,14 @@
.lux-time-datepicker {
@apply border-[#767676] border-[1px] pl-1;
}

.lux-attribution {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If lux-attribution is only used once, can't we achieve the same with tailwind classes within the component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having all my styles in a css file, but ok, moved to component template if you think it is better like this 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm just worried, we'll and up with a very long CSS file like in the legacy, making styles less readable.

@AlitaBernachot
Copy link
Contributor Author

Thanks, @AlitaBernachot! Works as expected, just left a comment regarding CSS organization. An e2e test could also be nice, but not mandatory. I'll let you decide.

Thx for the review! I have added some e2e testing.

@AlitaBernachot AlitaBernachot merged commit 6a8e915 into main Oct 19, 2023
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-659-attributions branch October 19, 2023 13:05
@AlitaBernachot AlitaBernachot mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlitaBernachot @tkohr