GSLUX-650: Time layers on map #86
Conversation
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-650-TimeLayersMap/ |
AlitaBernachot
force-pushed
the
GSLUX-650-TimeLayersMap
branch
2 times, most recently
from
414ad16
to
d5d501d
Compare
AlitaBernachot
force-pushed
the
GSLUX-650-TimeLayersMap
branch
from
d5d501d
to
e5b6d97
Compare
There was a problem hiding this comment.
Thanks for this nice functionality and the refactoring @AlitaBernachot !
One minor things I noticed when testing was that the slider-thumb does not always land exactly on the click position when clicking on the slider on the first click, while it does on the second click. But I think this can be improved later.
| } else if (+(maxValue.value - value) < +(minValue.value - value)) { | ||
| maxValue.value = value | ||
| } else { | ||
| maxValue.value = value |
There was a problem hiding this comment.
Shouldn't this be minValue to move the left slider if the click is closer to it?
There was a problem hiding this comment.
You are right, thx!
| olLayer.setOpacity(layer.opacity as number) | ||
|
|
||
| if (layer.metadata?.hasOwnProperty('attribution')) { | ||
| // TODO: fix this to display attribution, but at that time, this brokes the vue runtime-dom |
There was a problem hiding this comment.
Maybe needs a rebase after the attribution merge?
There was a problem hiding this comment.
Indeed, will remove this since attribution is now handled by a vue component.
|
|
||
| const olLayer = new MapLibreLayer({ | ||
| maplibreOptions: options, | ||
| label: layer.name, |
There was a problem hiding this comment.
Could also be included in destructuring.
AlitaBernachot
force-pushed
the
GSLUX-650-TimeLayersMap
branch
2 times, most recently
from
e84a455
to
a4a87f8
Compare
AlitaBernachot
force-pushed
the
GSLUX-650-TimeLayersMap
branch
from
a4a87f8
to
f9daa66
Compare
Thank you for reporting this! some unneeded extra watchers were causing this. Now, it is fixed. |
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-650
Description