Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSLUX-620: Traductions manquantes pour les layers #68

Merged
merged 5 commits into from
Aug 18, 2023
Merged

GSLUX-620: Traductions manquantes pour les layers #68

merged 5 commits into from
Aug 18, 2023

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Aug 14, 2023 •
edited
Loading

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-620

Description

Translation files (for all lang) need an update.
Some translations are missing, especially for new layers, see image below:

image (2) (1)

Done:

  • Updated all client.json (x4)
  • Fix i18n key for layer panel title ("layers" instead of "Layers")
  • Added <h1> for accessibility
  • Fix missing translation when bg layer is blank in prod mode build for lib (in dev, empty translation - eg. "My translation": "" - is replaced by the key, in prod, empty translation is kept)

Edit

  • Updated themes fixtures, now catalog is up to date

@github-actions
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-620-TraductionsLayers/

@AlitaBernachot AlitaBernachot force-pushed the GSLUX-620-TraductionsLayers branch 2 times, most recently from c955937 to 30a5019 Compare August 16, 2023 08:47
mki-c2c
mki-c2c approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my information, how do you extract the translation files from the v3 deployment ?
Is it manual or automatic extraction ?

bundle/assets/locales/client.de.json Outdated
@@ -1721,5 +1721,6 @@
"Buildings": "Gebäude",
"Water": "Hydrologie",
"Arrière-fond": "Hintergrund",
"Hillshade": "Relief"
"Hillshade": "Relief",
"main_culture": "Culture"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem like a correct German translation, where is the source for it ?

public/assets/locales/client.de.json Outdated
@@ -1721,5 +1721,6 @@
"Buildings": "Gebäude",
"Water": "Hydrologie",
"Arrière-fond": "Hintergrund",
"Hillshade": "Relief"
"Hillshade": "Relief",
"main_culture": "Culture"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem like a correct German translation, where is the source for it ?

Copy link
Contributor Author

@AlitaBernachot AlitaBernachot Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this, I have made a wrong copy/past. Now the client.de.json is up to date.
All translations files have been updated with a manual copy of static files from prod (eg. https://map.geoportail.lu/static/7ab2ad3b3c504ca7ba46f9cdec201f72/de.json?cache=7ab2ad3b3c504ca7ba46f9cdec201f72)

@mki-c2c
Copy link
Contributor

mki-c2c commented Aug 18, 2023 •
edited
Loading

the PR breaks the V4 demo app, the themes fixture does not seem to be in line with the translations.
image

@mki-c2c mki-c2c self-requested a review August 18, 2023 10:14
mki-c2c
mki-c2c requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@mki-c2c mki-c2c left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the catalog/themes fixture and the translations are in line... To be discussed

Probably the catalog for v4 has to be updated:
image

@AlitaBernachot
Copy link
Contributor Author

AlitaBernachot commented Aug 18, 2023 •
edited
Loading

Not sure if the catalog/themes fixture and the translations are in line... To be discussed

Probably the catalog for v4 has to be updated:
image

Ok, I have updated the fixtures, now the catalog content is the same as in prod.

mki-c2c
mki-c2c approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I can also see from your comment how to recover the translation data from prod server.

@AlitaBernachot AlitaBernachot merged commit a5e987a into main Aug 18, 2023
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-620-TraductionsLayers branch August 18, 2023 13:28
@AlitaBernachot AlitaBernachot mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mki-c2c mki-c2c mki-c2c approved these changes

@tkohr tkohr Awaiting requested review from tkohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlitaBernachot @mki-c2c