Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-765: FIX drawing #172

Merged
merged 5 commits into from
Nov 19, 2024
Merged

GSLUX-765: FIX drawing #172

merged 5 commits into from
Nov 19, 2024

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Nov 18, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-765

Description

Fix:

  • style on button: was purple(why???) with exaggerated rounded corner too different from prod
  • enable Escape keyup handler when drawing
  • update coordinates for drawing modale when modifying drawn feature

Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-765-fix-drawing/

Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this is fine, thanks for the improvements.

I have some reserves concerning the Anchor update. This popup dragging is not present in V3.
Improvements with better useability would be:

  • automatically move the popup out of the way of the active part of the drawing
  • or enable manual dragging of the popup

I find it especially strange, when the popup moves in the opposite direction of a line vertex when creating a narrow v-shaped linestring.

src/services/utils.ts Outdated Show resolved Hide resolved
@AlitaBernachot
Copy link
Contributor Author

This popup dragging is not present in V3.

Indeed, I have made some changes in the code to just update the modal anchor with a debounce, no more dragging effect.

  • automatically move the popup out of the way of the active part of the drawing
  • or enable manual dragging of the popup

Agree, it would have been nice to have the ability to move the modal but this is a whole new functionality, should be discussed first with client.

I find it especially strange, when the popup moves in the opposite direction of a line vertex when creating a narrow v-shaped linestring.

This should be less visible as there is now a debounce when modifying the geom.

Is it better now?

@mki-c2c
Copy link
Contributor

mki-c2c commented Nov 19, 2024

yes, it's better, nice. 👍

I don't see the point of moving the popup, but why not.

@AlitaBernachot
Copy link
Contributor Author

AlitaBernachot commented Nov 19, 2024

I don't see the point of moving the popup, but why not.

Why? => The center of the geom is supposed to be the modal anchor (it is how it is calculated).
You can move the geom far far far away from the modal. You won't see the info nor the profile updated.

Here is an example in prod where the modal stays in place:

image

@AlitaBernachot AlitaBernachot merged commit c8a2aea into main Nov 19, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-765-fix-drawing branch November 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants