-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSLUX-765: FIX drawing #172
Conversation
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-765-fix-drawing/ |
56e6acc
to
42dda06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this is fine, thanks for the improvements.
I have some reserves concerning the Anchor update. This popup dragging is not present in V3.
Improvements with better useability would be:
- automatically move the popup out of the way of the active part of the drawing
- or enable manual dragging of the popup
I find it especially strange, when the popup moves in the opposite direction of a line vertex when creating a narrow v-shaped linestring.
Indeed, I have made some changes in the code to just update the modal anchor with a debounce, no more dragging effect.
Agree, it would have been nice to have the ability to move the modal but this is a whole new functionality, should be discussed first with client.
This should be less visible as there is now a debounce when modifying the geom. Is it better now? |
yes, it's better, nice. 👍 I don't see the point of moving the popup, but why not. |
Why? => The center of the geom is supposed to be the modal anchor (it is how it is calculated). Here is an example in prod where the modal stays in place: |
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-765
Description
Fix: