Xp Storage: Update sneaking check and fix visual bug #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bug where it displayed "Stored Experience: Points" if no xp was stored yet, with `join` advancement that sets your score to 0 if needed - Moved sneaking check to predicate instead of scoreboard - Depositing all levels can be done instantly (without having to deposit 1 level first, so it would work when sneaking onto an ender chest without un-sneaking first) - Updated all comments in right formatting
misode
approved these changes
Aug 1, 2021
There was a problem hiding this comment.
This has a feature change in that you no longer need to deposit one level in order to deposit all, a clock cycle later, but this is a change that makes sense to me.
Maybe have a look if you can fix #387 but not a big deal otherwise.
SpecialBuilder32
added
quality-update
|
I'm gonna merge this; even though #387 isn't fixed, it's been around for so long we can address it after the 1.17 update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joinadvancement that sets your score to 0 if needed