Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sneak-depositing 800 or more levels exceeds the max command length #387

Open
misode opened this issue Apr 5, 2020 · 0 comments
Open

Sneak-depositing 800 or more levels exceeds the max command length #387

misode opened this issue Apr 5, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@misode
Copy link
Member

misode commented Apr 5, 2020

Describe the bug

It is possible to hit the max command chain length limit (65536). This will cause the gm4_xp_storage:main function to stop running.

To Reproduce

Steps to reproduce the behavior:

  1. /xp set @s 800 levels
  2. Stand on an enderchest and deposit one level
  3. Sneak and notice your xp level drops to 749
  4. Notice you can no longer deposit xp and the actionbar message is not appearing anymore

Fix

This is a temporary fix, but decreasing the 50 levels limit would decrease the chance of this happening in survival. In the future we should look into optimizing the xp depositing algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants