Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate which tests are run on push, and which are on PR? #103

Open
Tracked by #101
podhrmic opened this issue Jul 20, 2021 · 0 comments
Open
Tracked by #101

Separate which tests are run on push, and which are on PR? #103

podhrmic opened this issue Jul 20, 2021 · 0 comments
Labels
stretch Stretch goal, low priority

Comments

@podhrmic
Copy link
Collaborator

podhrmic commented Jul 20, 2021 •
edited
Loading

My recommendation is to:

  • run only test-examples on each push (runtime of ~4min, example of a test run here
  • run test-configs and test-notebooks on PR against develop (runtime ~20min)

A thing to consider is to run the tests inside docker as well, but perhaps only for PRs against develop (or nightly/weekly on develop?) - the runtime doubles (as each test has to be run twice), so still sub 1hr for a complete test.
@podhrmic podhrmic mentioned this issue Jul 20, 2021
Closed
10 tasks
@podhrmic podhrmic added the stretch Stretch goal, low priority label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stretch Stretch goal, low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@podhrmic