-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add photon shooting #82
Conversation
This PR is ready for review. I expect it to take a while since it is so big. If you'd like it broken up, feel free to suggest ways to do so. |
Hi @beckermr - just an update. I'm making good progress with the review and should be finished in the next couple of days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @beckermr - here is my initial review. Couldn't find any major issues or bugs, although I do have minor suggestions and questions.
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com>
OK @ismael-mendoza. Back to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
This PR is another monster. I am happy to break it up for folks if needed. The main reason it got so big is that I wanted to ensure enough tests were running that I flushed out all of the bugs. There were quite a few in fact.
Main features:
To do: