EditScopePlugValueWidget : Display lock icon next to read-only nodes #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
force-pushed
the
readOnlyEditScopeIndicator
branch
from
4d8f55c
to
0ce2c7c
Compare
murraystevenson
force-pushed
the
readOnlyEditScopeIndicator
branch
from
0ce2c7c
to
e956752
Compare
|
Pushed an alternate take on this that overlays a lock on top of our now larger node swatches.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little padlock icon next to read-only nodes in the EditScope menu as a hint that the edit scope you are about to select is locked and not editable. As this icon replaces the node colour swatch, I've tinted it based on the node colour so we don't lose that information on read-only edit scopes. The end result may be a little subtle given the limited real-estate available for a menu icon, but see what you think. I'm also not too beholden to the
Image._tint()method for tinting the icon, so if there are better ideas, I'm all ears...