Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set global dark theme preference when switching theme #231

Open
Jacalz opened this issue Nov 29, 2022 · 1 comment
Open

Set global dark theme preference when switching theme #231

Jacalz opened this issue Nov 29, 2022 · 1 comment
Labels
blocker Items that would block a forthcoming release enhancement New feature or request

Comments

@Jacalz
Copy link
Member

Jacalz commented Nov 29, 2022

Is your feature request related to a problem? Please describe:

It is now common place in Gnome (and possibly KDE Plasma as well) to set a global DBus value depending on dark/light theme preference. Fyne v2.3.0 will start watching this setting (fyne-io/fyne#2657) but we do not currently set it in Fynedesk.

It believe it would be good if we could set it here to make sure that non Fyne apps (if the user has GTK+4+libadwaita apps or anything else that supports it) follow the preference.

Is it possible to construct a solution with the existing API?

I think so but it might be that we are using the fyne_settings application. In that case, it probably only makes sense to set the DBus preference when running inside Fynedesk. It should be up to the desktop environment to set it in my opinion.

Describe the solution you'd like to see:

Switching between light and dark mode sets the DBus setting that makes sure that all applications that support it automatically follow light and dark preferences.

@andydotxyz
Copy link
Contributor

Excellent idea, let's make sure we get this into the next release (after Fyne v2.3.0)

@andydotxyz andydotxyz added enhancement New feature or request blocker Items that would block a forthcoming release labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants