ISSUE-9: Changes requested in review

FrendsPlatform · Dec 4, 2023 · 4a6bda6 · 4a6bda6
1 parent e789e4c
commit 4a6bda6
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 11 deletions.
diff --git a/Frends.OAuth.CreateJWTToken/CHANGELOG.md b/Frends.OAuth.CreateJWTToken/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Changelog
 
-## [1.1.0] - 2023-11-XX
+## [1.1.0] - 2023-12-04
 ### Added
 - Not Before claim set to optional. Added feature to add customer headers to JWT header.
 

diff --git a/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/CreateJWTToken.cs b/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/CreateJWTToken.cs
@@ -34,13 +34,13 @@ public static TokenResult CreateJWTToken(Input input)
         else
         // Default is to use stream and assume PEM format.
         {
-            var rsa = RSA.Create();
-            rsa.ImportFromPem(input.PrivateKey);
-
-            signingCredentials = new SigningCredentials(key: new RsaSecurityKey(rsa), algorithm: input.SigningAlgorithm.ToString())
-            {
-                CryptoProviderFactory = new CryptoProviderFactory { CacheSignatureProviders = false }
-            };
+            using var rsa = RSA.Create();
+            rsa.ImportFromPem(input.PrivateKey);
+
+            signingCredentials = new SigningCredentials(key: new RsaSecurityKey(rsa), algorithm: input.SigningAlgorithm.ToString())
+            {
+                CryptoProviderFactory = new CryptoProviderFactory { CacheSignatureProviders = false }
+            };
         }
         return new TokenResult(CreateToken(signingCredentials, input, isSymmetric));
     }

diff --git a/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/Definitions/CustomHeader.cs b/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/Definitions/CustomHeader.cs
@@ -8,10 +8,12 @@ public class CustomHeader
     /// <summary>
     /// Key of the header.
     /// </summary>
+    /// <example>kid</example>
     public string Key { get; set; }
 
     /// <summary>
     /// Value for the header.
     /// </summary>
+    /// <example>fsabijfbodsafadsfn</example>
     public string Value { get; set; }
 }
diff --git a/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/Definitions/JwtClaim.cs b/Frends.OAuth.CreateJWTToken/Frends.OAuth.CreateJWTToken/Definitions/JwtClaim.cs
@@ -1,4 +1,6 @@
-namespace Frends.OAuth.CreateJWTToken.Definitions;
+using System.ComponentModel.DataAnnotations;
+
+namespace Frends.OAuth.CreateJWTToken.Definitions;
 
 /// <summary>
 /// Class for describing of a single claim.
@@ -8,12 +10,14 @@ public class JwtClaim
     /// <summary>
     /// Claim key.
     /// </summary>
-    /// <example>Name</example>
+    /// <example>Role</example>
+    [DisplayFormat(DataFormatString = "Text")]
     public string ClaimKey { get; set; }
 
     /// <summary>
     /// Claim value.
     /// </summary>
-    /// <example>Value</example>
+    /// <example>Administrator</example>
+    [DisplayFormat(DataFormatString = "Text")]
     public string ClaimValue { get; set; }
 }