Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureBlobStorage.UploadBlob - add support for folders inside the container #92

Open
RikuVirtanen opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@RikuVirtanen
Copy link
Contributor

Task can't handle nested containers inside the container name parameter if CreateContainerIfItDoesNotExist parameter is enabled. The Task uses await container.CreateIfNotExistsAsync(PublicAccessType.None, null, null, cancellationToken) with the complete string set in the container name parameter and if the container name is e.g. "test/container/01", the method can't find the container at all and the Task will fail even when the container exists. The Task needs to be able to handle nested containers with that parameter enabled.

@RikuVirtanen RikuVirtanen added the bug Something isn't working label Nov 18, 2024
@MichalFrends1 MichalFrends1 self-assigned this Nov 20, 2024
@jefim jefim changed the title AzureBlobStorage.UploadBlob - bug with nested containers AzureBlobStorage.UploadBlob - add support for folders inside the container Nov 20, 2024
@jefim
Copy link
Contributor

jefim commented Nov 20, 2024

I have spoken to Riku and we came to this:

  1. We need to validate the container name parameter for it not to include slashes ( \ and / ). Throw an error to user if those are in the container name.
  2. We need to add a new parameter to destination: TargetFolder. This then should be prepended to the blob names when we upload those. This will enable us to create those directories.
  3. In the source parameters we need to rename two parameters for clarity:
  • BlobName should become RenameToBlobName
  • BlobFolderName should become RenameToFolderName
  1. This is a breaking change, so bump the major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@jefim @RikuVirtanen @MichalFrends1 and others