-
|
My question comes from here |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 3 replies
-
|
The correct way is to display them when they are available in the response from YouTube (e.g. search results) and otherwise not. |
Beta Was this translation helpful? Give feedback.
-
|
Could you point me to the specific function that fetches YouTube search results or any other response you are talking about? Are you saying we shouldn't build some cache (if it doesn't exist, I don't know you haven't answered my question) to support this feature? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I am saying don't build a cache, we don't do it for anything else, e.g. if the published date is missing then we just don't show it, same goes for the view count and duration and many other things. The subscriptions page is the only one I would say that you should use the thumbnail URL from the profiles. The easiest way to navigate around the code if you don't know it well is to start in the file for the page you are interested in. Each page in FreeTube has a subfolder in the |
Beta Was this translation helpful? Give feedback.
-
Figured this part myself, that's how I got to implement the feature for the subscribers tab!
Alright, since it already works for subs, I guess I can leave it like this and open the PR. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Closing as PR is opened so discussion can be continued over there. |
Beta Was this translation helpful? Give feedback.
Yes, I am saying don't build a cache, we don't do it for anything else, e.g. if the published date is missing then we just don't show it, same goes for the view count and duration and many other things.
The subscriptions page is the only one I would say that you should use the thumbnail URL from the profiles.
The easiest way to navigate around the code if you don't know it well is to start in the file for the page you are interested in. Each page in FreeTube has a subfolder in the
src/renderer/viewsfolder. When you are inside a JavaScript file and have found a function that you are interested in, most editors have a way to jump to that functions definition, in VSCode you can do that by C…