Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json Patching Support #99

Open
niemyjski opened this issue Jun 22, 2022 · 0 comments
Open

System.Text.Json Patching Support #99

niemyjski opened this issue Jun 22, 2022 · 0 comments

Comments

@niemyjski
Copy link
Member

I removed some usages of JSON.NET down to where our only usage is pretty much the JSON patch support.

Spent some time taking a look at json-everything's JsonPatch support and it only uses JSON Pointers for paths and does not support some of the things we are doing where we are allowing full JSON Path support where we can do things like $.books[?(@.author == 'John Steinbeck')] to remove all array elements from the books array that has an author sub-property that matches John Steinbeck. So basically we would need to make major changes to their libraries or talk them into supporting JSON Path expressions even though the unofficial JSON Patch spec only supports JSON Pointer.

Originally posted by @ejsmith in #96 (comment)

Found this issue where someone asked him and he said no to supporting JSON Path.

Originally posted by @ejsmith in #96 (comment)

Comment for previous history:

For Json Patching it would be nice to see if we can get it to work without a dependency or we can internalize the dependency. I see several spots doing patching

Originally posted by @niemyjski in #96 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant