Vacuum may delete a directory without putting it into the recycle bin

[ForNeVeR]

Today, I've noticed that while removing a directory T:\Temp\Rider2023.1 (18.49 GiB), Vacuum has deleted it entirely, and not moved to the recycle bin.

Some hypothesis on what could cause that behavior:

• the directory is too big to be put into the recycle bin
• some files are too big
• some paths are too long

Normally, Windows Shell will ask the user what to do, but it's possible that some flags we are passing to it lead to just deleting the directory in case of questions.

Deserves further investigation.

[ForNeVeR]

Steps to reproduce:

$ md T:\Temp\vac-wsp
$ cd T:\Temp\vac-wsp
$ fsutil file createnew test 18000000000 # creates a file of 18 GB in size
$ vacuum -d T:\Temp\vac-wsp # deletes the file without putting it into the recycle bin
Removing file T:\Temp\vac-wsp\test… ok

[ForNeVeR]

Here's what it says if I'm trying to recycle it manually.

[ForNeVeR]

Alright, the current plan will be to use IFileOperation manually (perhaps extract it into a reusable library later), and try handling the results.

Ideally, we'd want to properly handle the deletion states: by default, do not delete such a file and properly detect the status, and only force-delete it if called with --force.