-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shield Modifiers #110
Comments
Add the compatibility for the shield in off hand (so it can trigger modifier and exp) |
Maybe these effects could optionally be incompatible (just like the protection modifiers) too. |
I think except for Reinforced (unbreaking) and mending non of the vanilla enchantments work on the shield. (and need to be implemented by us?) |
Knockback works on all items in the game which is why I added it. I'm not sure about any others though and I don't plan on testing if any work. |
https://minecraft.gamepedia.com/Shield |
See #81 for more Modifier ideas for the shield |
The effects from hitting the shield could be combined with some ideas in the other issue. |
With the ideas in this issue I'm mainly thinking of people swapping with the F key (default for en_US layouts) and hitting things with their shields, then swapping back with F. You can block with your shield in either hand (and can block with two shields if there's on in each hand) so I don't see it as too unintuitive. We could make descriptions something like "Bashing with shield applies weakness to the target." |
It would be optimal if you could left click while blocking to "Shield Bash" but minecraft doesn't support that and I don't think there's a way to simulate it. Swapping and hitting would likely be the best compromise if there's no better ways to do it. Alternatively, applies the effect(s) when hit while blocking? |
I'm not sure if all servers would like having these enabled or how long / strong the effects should be (though both of those things should be configurable), but I don't see any harm in adding them anyway as they can be disabled.
The text was updated successfully, but these errors were encountered: