Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need a real usage example #14

Open
kneufeld opened this issue Mar 25, 2019 · 4 comments
Open

need a real usage example #14

kneufeld opened this issue Mar 25, 2019 · 4 comments

Comments

@kneufeld
Copy link

I just wasted a good hour because I had http://localhost:8000/ws as the websocket_url instead of ws://localhost:8000/ws. Yes I know that's on me but having usage examples are absolutely key for any project.

@Fitblip
Copy link
Owner

Fitblip commented Mar 25, 2019

Hi @kneufeld - what behavior did you encounter when using http:// instead of ws://?

Additionally, I'm always open to PRs. Since you've found an edge here in terms of usability, you're the best person to propose a change that would ensure others don't run into the same problem that you did.

Thanks!

@skamieniarz
Copy link

@Fitblip, I've prepared a real usage example in the description at README.md and wanted to push the branch to create a PR, but apparently, I don't have correct access rights:

ERROR: Permission to Fitblip/wsstat.git denied to skamieniarz.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights

@katafractari
Copy link

Upgrade and Connection headers are not sent if I use http:// as protocol. They are only send if I use ws://. I'm not sure if this is the correct behaviour since I'm new to websockets.

@Fitblip
Copy link
Owner

Fitblip commented May 6, 2019

Ok, so it sounds like the real issue here is that we're not erroring out if you specify non-ws protocols (namely http://), which is for some reason attempted by the websocket library we're using.

When I get time I'll fix it, or if one of you wants to tackle it PRs are always welcome!

Also @skamieniarz - you don't have permissions to this repository due to how Github works. If you want to submit a pull request you need to fork this repo and submit a PR from your fork.

Thanks!
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants